[FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

Lukasz Marek lukasz.m.luki2 at gmail.com
Sat Nov 22 01:16:52 CET 2014

On 21.11.2014 23:17, Reynaldo H. Verdejo Pinochet wrote:
> Hi
> On 11/20/2014 10:14 PM, Lukasz Marek wrote:
>> On 18.11.2014 21:35, Reynaldo H. Verdejo Pinochet wrote:
>> [...]
>> Also, please make an effort
>>> to break lines at 80 chars as long as it doesn't make the
>>> code harder to read. This seems particularly possible on the
>>> function declarations.
>> regarding this part, I set my editor to notice 90 chars and I try to
>> respect that, but with some reasonable margin. TBH, 80 chars is
>> prehistoric, probably from the era of crt's with text mode.
>> I don't remember official ffmpeg's rules about that, but common, its
>> 21th century...
> https://www.ffmpeg.org/developer.html#toc-Code-formatting-conventions
> Please try to when possible. It's not a requirement but a sane
> suggestion many avid by.

updated patch attached,

Regarding 80 chars it is just my opinion. The link says to do it only 
when readability doesn't decrease and I try to do it this way tbh.
I made few changes in new versions and will keep it in mind in future, 
but probably this was last so big patchset for ffserver* of mine.

Off topic:
This all is kinda funny:


and this recall me

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ffserver_config-map-ffserver-options-to-AVOptions.patch
Type: text/x-patch
Size: 22374 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141122/88db4b6c/attachment.bin>

More information about the ffmpeg-devel mailing list