[FFmpeg-devel] [PATCH 1/1] ffv1dec: Avoid unnecessarily large stack usage and copies.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Nov 22 19:09:04 CET 2014


On Sat, Nov 22, 2014 at 02:42:25PM +0100, Michael Niedermayer wrote:
> On Sat, Nov 22, 2014 at 02:14:13PM +0100, Reimar Döffinger wrote:
> > Ideally the compiler could figure this out on its own,
> > but it seems it can't.
> > An alternative that would avoid the messy explicit memcpy
> > would be to use a sub-struct for the parts that should
> > be preserved, which can then simply be assigned.
> > 
> > Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> > ---
> >  libavcodec/ffv1dec.c | 15 ++++++++++-----
> >  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> LGTM

Thanks, pushed.


More information about the ffmpeg-devel mailing list