[FFmpeg-devel] [PATCH 03/11] ffserver_config: map ffserver options to AVOptions

Lukasz Marek lukasz.m.luki2 at gmail.com
Wed Nov 26 23:52:27 CET 2014


On 26.11.2014 23:22, Reynaldo H. Verdejo Pinochet wrote:
> Hi
>
> On 11/21/2014 09:16 PM, Lukasz Marek wrote:
>> [...]
>> @@ -497,6 +500,14 @@ static int ffserver_save_avoption(const char *opt, const char *arg, int type, FF
>>       return 0;
>>   }
>>
>> +static int ffserver_save_avoption_int(const char *opt, int64_t arg,
>> +                                      int type, FFServerConfig *config)
>> +{
>> +    char buf[30];
>
> char buf[20] should be plenty considering INT64_MAX. Feel free to push
> after this minor fix unless someone else holds you.

In fact 20 is too small. INT64_MIN has 19 digits, '-' sign and 
terminating 0. So 21 is a minimum. I put 22, the same as av_dict_set_int.




More information about the ffmpeg-devel mailing list