[FFmpeg-devel] [PATCH] msvc: Fix compilation errors due to header include order.

Matt Oliver protogonoi at gmail.com
Thu Nov 27 12:38:01 CET 2014


The patch "lavf: Use wchar functions for filenames on windows for
mkdir/rmdir/rename/unlink" that was recently added has broken msvc/icl
builds. see:
http://fate.ffmpeg.org/report.cgi?time=20141126233318&slot=x86_32-msvc12-windows-native

This is because winsock2.h must be included before windows.h. There are
many other files that include windows.h that dont check for winsock2.h (as
they dont need it) but include avformat/internal.h which now includes
winsock2.h but after all the files that explicitly include their own
windows.h. As a result all these files now wont compile under msvc/icl and
generate warnings under mingw.

The attached patch fixes that by ensuring the correct header include order.

Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-msvc-Fix-compilation-errors-due-to-header-include-or.patch
Type: application/octet-stream
Size: 2161 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141127/d9019cb9/attachment.obj>


More information about the ffmpeg-devel mailing list