[FFmpeg-devel] [PATCH] msvc: Fix compilation errors due to header include order.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Fri Nov 28 17:47:01 CET 2014

On Thu, Nov 27, 2014 at 10:38:01PM +1100, Matt Oliver wrote:
> The patch "lavf: Use wchar functions for filenames on windows for
> mkdir/rmdir/rename/unlink" that was recently added has broken msvc/icl
> builds. see:
> http://fate.ffmpeg.org/report.cgi?time=20141126233318&slot=x86_32-msvc12-windows-native
> This is because winsock2.h must be included before windows.h. There are
> many other files that include windows.h that dont check for winsock2.h (as
> they dont need it) but include avformat/internal.h which now includes
> winsock2.h but after all the files that explicitly include their own
> windows.h. As a result all these files now wont compile under msvc/icl and
> generate warnings under mingw.
> The attached patch fixes that by ensuring the correct header include order.

That doesn't explain why the patch changes the zlib / bz2 include position?

More information about the ffmpeg-devel mailing list