[FFmpeg-devel] [PATCH 1/6] bitstream_filter: add an init function

Christophe Gisquet christophe.gisquet at gmail.com
Sun Nov 30 10:21:54 CET 2014


2014-11-30 4:08 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> this breaks ABI/API
> why is what is done in init not just done in the first packet when
> the args are already available ?
> This seems simpler and would avoid introducing a API that is possibly
> going to be deprecated once a AVOption or AVDictionary based one is
> introduced

In the case of the targeted filter, the arguments are only needed
once. So indeed, the SPS filter code does that and tracks that it has
already parsed the argument string. Probably it's the job of the
caller to know the filter behaves like that, and to pass only once
arguments that don't change.

The actual issue is with ffmpeg*.c, and probably out of laziness from
both the original author and myself. The arguments would be used in a
place completely unrelated to the parsing of the string containing the
filters (and now the parameters). So you have to probably add a
construct to OutputStream to store, and maintain, and synchronize the
bsf <-> arg association.


More information about the ffmpeg-devel mailing list