[FFmpeg-devel] [PATCH 3/6] h264_changesps_bsf: import code

Christophe Gisquet christophe.gisquet at gmail.com
Sun Nov 30 10:43:01 CET 2014


2014-11-30 1:45 GMT+01:00 Christophe Gisquet <christophe.gisquet at gmail.com>:
> From: Zongyi Zhou <zhouzy at os.pku.edu.cn>
> Mostly unverified, but seems to have been extensively tested here:
> http://forum.doom9.org/showthread.php?t=152419

For the record, I don't think I'm making a good argument for this patch.

Committing that amount of code is kind of dangerous, but then the
options are 1) to completely review it (important amount of work in
particular if you consider the security issues) or 2) keep the only
tested piece. Removing and re-adding the code is non-trivial.


More information about the ffmpeg-devel mailing list