[FFmpeg-devel] [PATCH 2/2] compat/w32pthreads: use the condition variable API directly when targeting newer versions of Windows

Michael Niedermayer michaelni at gmx.at
Thu Oct 9 13:07:51 CEST 2014

On Wed, Oct 08, 2014 at 10:51:55PM -0300, James Almer wrote:
> Wrap the function calls in a similar fashion to how it's being done
> with the critical section API.
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  compat/w32pthreads.h | 64 +++++++++++++++++++++++++++++++---------------------
>  1 file changed, 38 insertions(+), 26 deletions(-)

maybe ok (i dont know these APIs, but i see nothing wrong in the patch)


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141009/8d5027ad/attachment.asc>

More information about the ffmpeg-devel mailing list