[FFmpeg-devel] [PATCH] Fix writing first audio Cues in dash mode.

Michael Niedermayer michaelni at gmx.at
Thu Oct 9 22:07:38 CEST 2014


On Thu, Oct 09, 2014 at 09:03:29AM -0700, Vignesh Venkatasubramanian wrote:
> On Thu, Oct 9, 2014 at 8:28 AM, Frank Galligan <frankgalligan at gmail.com> wrote:
> > In dahsmode Matroska is not writing the first Cluster for every
> > audio stream in the Cues element.
> >
> > Signed-off-by: Frank Galligan <frankgalligan at gmail.com>
> > ---
> >  libavformat/matroskaenc.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> > index 4af2d6e..00a0c18 100644
> > --- a/libavformat/matroskaenc.c
> > +++ b/libavformat/matroskaenc.c
> > @@ -1770,7 +1770,8 @@ static int mkv_write_packet(AVFormatContext *s, AVPacket *pkt)
> >          // on seeing key frames.
> >          start_new_cluster = keyframe;
> >      } else if (mkv->is_dash && codec_type == AVMEDIA_TYPE_AUDIO &&
> > -               cluster_time > mkv->cluster_time_limit) {
> > +               (mkv->cluster_pos == -1 ||
> > +                cluster_time > mkv->cluster_time_limit)) {
> >          // For DASH audio, we create a Cluster based on cluster_time_limit
> >          start_new_cluster = 1;
> >      } else if (!mkv->is_dash &&
> > --
> > 2.1.0.rc2.206.gedb03e5
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> lgtm.

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141009/5dd63891/attachment.asc>


More information about the ffmpeg-devel mailing list