[FFmpeg-devel] [PATCH] ffmpeg_opt: add -seek_error option

Michael Niedermayer michaelni at gmx.at
Sat Oct 11 22:32:00 CEST 2014


On Fri, Oct 10, 2014 at 11:19:21PM +0200, Simon Thelen wrote:
> On 10/10/14 at 00:45, Michael Niedermayer wrote:
> > On Thu, Oct 09, 2014 at 11:22:07PM +0200, Simon Thelen wrote:
> > > On 09/10/14 at 23:05, Michael Niedermayer wrote:
> > > > On Wed, Oct 08, 2014 at 07:13:33PM +0200, Simon Thelen wrote:
> > > > > Enabling -seek_error causes ffmpeg to quit when it notices that
> > > > > stop_time <= start_time.
> > > > is there a reason not to stop and continue ?
> > > > iam asking as if not then this could be done unconditionally
> > > I can't think of a reason as to why somebody would want to continue, but
> > > I didn't want to mess with the default behavior so I thought a
> > > conditional would be cleaner.
> > > If you want, I can send another patch that makes exiting the default or
> > > gets rid of the conditional entirely.
> > 
> > well, its mostly a question what the community prefers
> > personally id just make it fail if what the user wants cant be
> > done, if noone has any other oppinion
>  
> I've attached a patch that makes ffmpeg abort in this case. If nobody
> else has any opinions on the issue, you can commit that one.
> 
> -- 
> Simon Thelen

>  ffmpeg_opt.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 873c406864dad27bf0b0bd97dc3c19ded8707176  0001-ffmpeg_opt-abort-if-to-ss.patch
> From edc569b9ea5aa1d2f2484d105ce090cfccbb76d9 Mon Sep 17 00:00:00 2001
> From: Simon Thelen <ffmpeg-dev at c-14.de>
> Date: Fri, 10 Oct 2014 23:04:01 +0200
> Subject: [PATCH] ffmpeg_opt: abort if -to <= -ss
> 
> Makes ffmpeg abort instead of continuing when stop_time <= start_time.
> 
> Closes ticket #4015.

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141011/684b13ea/attachment.asc>


More information about the ffmpeg-devel mailing list