[FFmpeg-devel] [PATCH] avformat/id3v2: only use syncsafe for extended header size.

Benoit Fouet benoit.fouet at free.fr
Tue Oct 14 11:08:28 CEST 2014


Hi,

Le 14/10/2014 10:51, Carl Eugen Hoyos a écrit :
> Benoit Fouet <benoit.fouet <at> free.fr> writes:
>
>> Another approach could be to check the next 
>> tag to see if the size is correct, and if 
>> not, fallback to 2.3 sizes for 2.4 tags.
>> Should I try that?
> Please do that.
>

OK.

> Do you already know what other software does?
> (It doesn't matter imo if checking the next 
> tag works.)

Since my last email, I've just checked what taglib does, and they seem
to have a hack to handle exactly the same, that is:
 - try the syncsafe size
 - read next tag
 - if not a tag, try the non-syncsafe size, read next tag, and use the
non syncsafe size if the tag is valid

I'll do that on Thursday, unless anyone beats me to it...

-- 
Ben




More information about the ffmpeg-devel mailing list