[FFmpeg-devel] [PATCH 1/4] ffserver: move configuration code to separate file

Stefano Sabatini stefasab at gmail.com
Tue Oct 21 12:08:30 CEST 2014


On date Monday 2014-10-20 23:56:59 +0200, Lukasz Marek encoded:
> This commit doesn't change any existing logic.
> It moves ffserver configuration related code to separate file.
> It intends to make maintaining easier.

I'm not opposed, but please tell why you think it's better this way. I
still hate the ffmpeg.c/ffmpeg_opt.c split, since it makes debugging
and browsing the code much harder for me, also it increases the
complexity since you have to declare otherwise static functions.

> Signed-off-by: Lukasz Marek <lukasz.m.luki2 at gmail.com>
> ---
>  Makefile          |    1 +
>  ffserver.c        | 1214 +++++------------------------------------------------
>  ffserver_config.c |  986 +++++++++++++++++++++++++++++++++++++++++++
>  ffserver_config.h |  118 ++++++
>  4 files changed, 1201 insertions(+), 1118 deletions(-)
>  create mode 100644 ffserver_config.c
>  create mode 100644 ffserver_config.h
-- 
FFmpeg = Furious Fascinating Multimedia Ponderous Enhancing Gigant


More information about the ffmpeg-devel mailing list