[FFmpeg-devel] [PATCH] lavd: export all symbols with av prefix

Lukasz Marek lukasz.m.luki2 at gmail.com
Tue Oct 21 23:05:40 CEST 2014


On 21.10.2014 08:59, James Almer wrote:
> On 20/10/14 5:03 PM, Lukasz Marek wrote:
>> On 20.10.2014 14:55, Michael Niedermayer wrote:
>>> On Mon, Oct 20, 2014 at 12:14:14PM +0200, Lukasz Marek wrote:
>>>> On 20 October 2014 08:47, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
>>>>
>>>>> On 19.10.2014, at 13:39, Lukasz Marek <lukasz.m.luki2 at gmail.com> wrote:
>>>>>
>>>>>> Signed-off-by: Lukasz Marek <lukasz.m.luki2 at gmail.com>
>>>>>> ---
>>>>>> libavdevice/libavdevice.v | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/libavdevice/libavdevice.v b/libavdevice/libavdevice.v
>>>>>> index 663af85..d7c86ba 100644
>>>>>> --- a/libavdevice/libavdevice.v
>>>>>> +++ b/libavdevice/libavdevice.v
>>>>>> @@ -1,4 +1,4 @@
>>>>>> LIBAVDEVICE_$MAJOR {
>>>>>> -        global: avdevice_*;
>>>>>> +        global: av*;
>>>>>
>>>>> I'd prefer if we'd keep the explicit _ termination and explicitly list all
>>>>> prefixes that get exported.
>>>>> I admit that luckily av is uncommon in English to start a word so it
>>>>> probably won't matter much though.
>>>>>
>>>>
>>>> I checked libavformat and libavcodec and they export av*, but I agree in
>>>> general so I have changed according to your suggestion.
>>>
>>>>    libavdevice.v |    2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>> 5722720606edb454d2b64edb06299b1a37099827  0001-lavd-export-all-symbols-with-av_-prefix.patch
>>>>   From ea5b124b9eac8a4e07f41860fba646c6bc55f5bd Mon Sep 17 00:00:00 2001
>>>> From: Lukasz Marek <lukasz.m.luki2 at gmail.com>
>>>> Date: Mon, 20 Oct 2014 12:12:20 +0200
>>>> Subject: [PATCH] lavd: export all symbols with av_ prefix
>>>
>>> LGTM
>>
>> Pushed.
>
> Should this be backported to ffmpeg 2.2 and 2.3? The four av_ functions declared in avdevice.h
> were never exposed before this.

Only to 2.3 (these symbols are not present in 2.2)
Michael, could you backport it?



More information about the ffmpeg-devel mailing list