[FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

Lukasz Marek lukasz.m.luki2 at gmail.com
Wed Oct 22 22:48:39 CEST 2014


On 22.10.2014 22:05, Reynaldo H. Verdejo Pinochet wrote:
> Hi
>
> On 10/20/2014 06:57 PM, Lukasz Marek wrote:
>> So far AVCodecContext was created without codec specified.
>> This causes internal data to not be initialized to defaults.
>>
>> This commit postpone context creation until all information are gathered.
> are/is

fixed

>> +    .video_opts = NULL,
>> +    .video_conf = NULL,
>> +    .audio_opts = NULL,
>> +    .audio_conf = NULL,
>> +    .video_preset = NULL,
>> +    .audio_preset = NULL,
>>   };
>>
>
> Guess you are already considered dropping the explicit initialization
> code as Reimaer suggested.
>
> Looks good otherwise. Feel free to push.

I will, but a bit later, tomorrow probably.
I need to apply Stefano's remarks and finally do some self review.



More information about the ffmpeg-devel mailing list