[FFmpeg-devel] [PATCH] Use v4l2 input format automatically if filename starts with "/dev/video"

wm4 nfxjfg at googlemail.com
Sat Oct 25 13:10:20 CEST 2014


On Sat, 25 Oct 2014 11:43:12 +0200
Nicolas George <george at nsup.org> wrote:

> Le tridi 3 brumaire, an CCXXIII, Timothy Gu a écrit :
> > Those URLs are very explicit, while `/dev/` can mean anything,
> > including `/dev/stdin`.
> 
> Andrey quoted these bits of code to show that checking filename for NULL is
> not necessary. I believe his proof is conclusive for that point.
> 
> wm4 :
> > IMHO it should check whether it's really a video device.
> 
> Yes, it should. Do you intend to propose the patch that invokes stat() on
> all supported operating systems, check that can not devolve into a security
> issue in the context of probing, find the relevant list of major/minor
> pairs and a way of testing the dynamically allocated ones soon, or are you
> just bikeshedding.

Don't present your extremely bad ideas as mine. Thanks.

> Because if you are just bikeshedding, I believe the patch with a lower
> score, EXTENSION instead of MAX maybe, would be fine.
> 
> Regards,
> 



More information about the ffmpeg-devel mailing list