[FFmpeg-devel] [PATCH] lavf/ffmdec: return proper error code in ffm2_read_header()

Stefano Sabatini stefasab at gmail.com
Mon Sep 1 17:00:03 CEST 2014


On date Monday 2014-09-01 14:34:23 +0200, Michael Niedermayer encoded:
> On Mon, Sep 01, 2014 at 02:05:56PM +0200, Stefano Sabatini wrote:
> > ---
> >  libavformat/ffmdec.c | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> > 
> > diff --git a/libavformat/ffmdec.c b/libavformat/ffmdec.c
> > index f8fee2f..d74b6cf 100644
> > --- a/libavformat/ffmdec.c
> > +++ b/libavformat/ffmdec.c
> > @@ -238,8 +238,12 @@ static int ffm2_read_header(AVFormatContext *s)
> >      AVCodecContext *codec;
> >  
> >      ffm->packet_size = avio_rb32(pb);
> > -    if (ffm->packet_size != FFM_PACKET_SIZE)
> > +    if (ffm->packet_size != FFM_PACKET_SIZE) {
> > +        av_log(s, AV_LOG_ERROR, "Invalid packet size %d, expected was %d\n",
> > +               ffm->packet_size, FFM_PACKET_SIZE);
> > +        ret = AVERROR(EINVAL);
> 
> theres no ret variable in the function
> is some hunk missing ?

Up.
-- 
FFmpeg = Fierce & Fast Moronic Proud Extreme Gangster
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lavf-ffmdec-return-proper-error-code-in-ffm2_read_he.patch
Type: text/x-diff
Size: 1625 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140901/97d6fd51/attachment.bin>


More information about the ffmpeg-devel mailing list