[FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

[Michael Niedermayer]

On Tue, Sep 02, 2014 at 01:52:24PM +0200, Jörg Krause wrote:
> 
> 
> Am 02.09.2014 12:40 schrieb Michael Niedermayer:
> >On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote:
> >>Add the feature test macro which is required for building with the
> >>musl toolchain.
> >>
> >>The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant
> >>version of strerror_r().
> >
> >is there a reason why you dont set it from configure ?
> >similar to the existing "-D_XOPEN_SOURCE=600" code in configure ?
> >
> >[...]
> 
> I followed the recommendation from the GNU C Library Reference
> Manual, ch. 1.3.4 Feature Test Macro:
> 
> You should define these macros by using ‘#define’ preprocessor
> directives at the top of your source code files. These directives
> must come before any #include of a system header file. It is best to
> make them the very first thing in the file, preceded only by
> comments. You could also use the ‘-D’ option to GCC, but it's better
> if you make the source files indicate their own meaning in a
> self-contained way.
> 
> Do you prefer to define the macro in configure?

i prefer that all libcs are handled the same way

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140902/05bfa46c/attachment.asc>