[FFmpeg-devel] [PATCH 0/2] avdevice/x11grab: fix cursor drawing in multi-screen setup
ao2 at ao2.it
Tue Sep 9 09:30:50 CEST 2014
On Tue, 9 Sep 2014 05:32:36 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Sep 08, 2014 at 01:15:17PM +0200, Antonio Ospite wrote:
> > Hi,
> > with multi-screen setups x11grab does not behave in the correct way wrt.
> > drawing the mouse cursor, e.g. when doing:
> > ffplay -f x11grab -i ":0.1"
> > the mouse cursor was drawn in the captured video even when the mouse
> > pointer was on :0.0.
> > The following patches fix the issue.
> > Patch 1 is just a preparatory change which has also the effect to
> > minimize the delta with the version of patch 2 I am sending to libav.
> > Patch 2 has the actual fix I came up with, look there for a detailed
> > description of the issue.
> > I can provide further info about how to replicate the issue with
> > a virtual screen using the xserver-xorg-video-dummy driver if anybody is
> > interested.
> > Thanks,
> > Antonio
> > Antonio Ospite (2):
> > avdevice/x11grab: rename the "w" Window to "root" in
> > paint_mouse_pointer
> > avdevice/x11grab: fix cursor drawing in multi-screen setup
> > libavdevice/x11grab.c | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
> patchset applied
>From a discussion on libav-devel it came out that the follow_mouse
option is broken too in multi-screen setups.
I will submit a patch for that too.
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
More information about the ffmpeg-devel