[FFmpeg-devel] [PATCH 1/4] avformat/utils: return EINVAL from seek_frame_generic() when the requested target appears to be outside the file duration

Michael Niedermayer michaelni at gmx.at
Thu Sep 11 20:42:49 CEST 2014

On Thu, Sep 11, 2014 at 08:08:43PM +0200, Reimar Döffinger wrote:
> On Thu, Sep 11, 2014 at 04:48:00PM +0200, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> Isn't that potentially a bit confusing?
> EINVAL sounds to me like I would expect a programming error,
> inputting something I should have known to be invalid.
> That's not quite the case for out-of-range timestamps.
> I guess it is better than -1 though, and I can't suggest
> anything better, I am just not really happy with it.

we can drop this patch, i dont mind at all, it was just to avoid some
EINVAL <-> -1 changes in the seektests caused by a later patch in
this series.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140911/b40eb586/attachment.asc>

More information about the ffmpeg-devel mailing list