[FFmpeg-devel] [PATCH 1/2] Fix miscompilation for i586.

Ronald S. Bultje rsbultje at gmail.com
Wed Sep 17 13:34:17 CEST 2014


On Wed, Sep 17, 2014 at 4:08 AM, Michael Niedermayer <michaelni at gmx.at>

> On Sun, Sep 14, 2014 at 01:01:45AM +0200, Mikulas Patocka wrote:
> In the program, you can easily determine what -march was passed to the
> > compiler and react to it - if one of __i686__, __athlon__, __SSE__ is
> > defined, you can use cmov, because the compiler is already generating
> > cmov.
> thats true,
> but maybe its better if you put this check in configure so the
> --enable/disable flags can be used to override it

+1 on this. For code that is clearly intended to be shared between
compilers (and many compilers support inline asm), I don't think we want to
use compiler-specific flags.


More information about the ffmpeg-devel mailing list