[FFmpeg-devel] [PATCH] Adobe HTTP Dynamic Streaming (HDS) demuxer improvements

[Gorilla Maguila]

I'll try to correct the patch and post it back.

2014-09-17 19:34 GMT+02:00 Carl Eugen Hoyos <cehoyos at ag.or.at>:

> Gorilla Maguila <gorilla.maguila <at> gmail.com> writes:
>
> > http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2014-February/154612.html
> >
> > I attach a new patch with improvements:
>
> I wanted to write an answer with a few minor remarks
> but just saw that several issues from the original
> review are still valid:
> http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/171211/focus=171212
> (missing av_log context, not using av_freep() which
> is safer, many unneeded and ugly casts, the probe
> function has a too high score or not enough tests)
> Maybe you should double-check for unchecked reads
> from external data, I cannot comment if they were
> fixed.
>
> Also please format if-else if like this:
> if(cond1) {
>   do1;
> } else if(cond2) {
> ...
>
> Note that "} else if" should be all in one line.
>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>