[FFmpeg-devel] Status of dvdsub "forced_subs_only" patch

Nicholas Robbins nickrobbins at yahoo.com
Thu Sep 18 17:36:36 CEST 2014

> On Wednesday, September 17, 2014 1:43 PM, Nicholas Robbins <nickrobbins-at-yahoo.com at ffmpeg.org> wrote:

> > 
>>  On Tuesday, September 16, 2014 1:34 PM, Nicholas Robbins 
> <nickrobbins-at-yahoo.com at ffmpeg.org> wrote:
>>  > Ok, I seem to have a partial solution.
>>  I thought that the place to put this would be in the dvdsubenc.c. So I made 
> the 
>>  following changes (sorry for inline patch)
> ....
>>  So, it seems like what I am doing produces a mangled dvdsub track, but one 
> that 
>>  ffmpeg can make sense of. It isn't just some muxing thing since if I 
> run 
>>  only.mkv through mkvmerge, it doesn't get fixed.
>>  How can I finish this patch?
> Any thoughts on this? I don't think I should submit this patch since it 
> produces corrupted tracks. But it works good enough for me (I just wash the 
> subtitle mkv with ffmpeg again) 

I've looked this over again and, while this is my first foray into encoders, I don't see why my patch should produce a corrupted dvdsub track. Any suggestions?


More information about the ffmpeg-devel mailing list