[FFmpeg-devel] [PATCH] Change deprecated use of _SVID_SOURCE to _DEFAULT_SOURCE

Carl Eugen Hoyos cehoyos at ag.or.at
Fri Sep 19 18:38:58 CEST 2014


Daniel Bomar <dbdaniel42 <at> gmail.com> writes:

> What should be tested in configure?

You wrote that compilation fails for you with an 
error, I originally assumed this can be reproduced 
with current FFmpeg git head (rereading our mail, 
I am not so sure).
If compilation fails, this can be tested in 
configure.

> IMO take this patch and if it breaks some old 
> systems (not sure why it would) have a configure
> option to revert this on those systems.

This does not sound like an acceptable approach to 
me.
If it is really more than unlikely that it breaks 
old systems, please explain why. From your 
explanation and without further reading, I would 
assume that it will break things easily (but I may 
absolutely be wrong in which case there is no 
argument against the patch).

If the issue is not reproducible with current 
FFmpeg, I wonder what should be fixed...

Please do not top-post here, Carl Eugen



More information about the ffmpeg-devel mailing list