[FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

Clément Bœsch u at pkh.me
Sun Sep 21 18:48:29 CEST 2014

On Sun, Sep 21, 2014 at 11:20:26AM +0200, Nicolas George wrote:
> Le jour de la Raison, an CCXXII, Clément Bœsch a écrit :
> > ---
> >  libavcodec/webvttdec.c | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> Patches 5-10 look right, except most of them could benefit from the
> factorization.

So I did that and pushed that part of the patchset, adjusted to use a
bprint helper.

Unfortunately, this raises a warning because av_bprint_is_complete()
doesn't take a const parameter. I was too lazy to actually fix the API,
but didn't want to cast to hide the warning. If you can send a patch to
fix the bprint API that would be really appreciated. Thanks :)

Thank you for your review,

Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140921/c61d5d79/attachment.asc>

More information about the ffmpeg-devel mailing list