[FFmpeg-devel] [PATCH 10/17] avcodec/webvttdec: add some memory checks

Clément Bœsch u at pkh.me
Sun Sep 21 19:41:00 CEST 2014

On Sun, Sep 21, 2014 at 07:36:19PM +0200, Nicolas George wrote:
> Le jour de la Récompense, an CCXXII, Clément Bœsch a écrit :
> > Doesn't this need at least a minor bump?
> I consider it a bug fix, not an API change. Can you imagine a case where
> people would need to check for it?

One case that might break is when used as a callback. That's very unlikely
to happen, but it's still a change in the public API. You might get some
rainbow colors from http://upstream-tracker.org/ typically.

> > Not really; in SAMI at least the buffer is allocated only once, and
> > finalized only at the end. This behaviour could be adopted in other
> > text subtitles demuxers.
> That makes sense, but you still could do it with an extra argument to select
> between finalize, clear and nothing.

Yeah maybe. That function will be dropped anyway, it's just in order to
ease the transition to the next API.


Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140921/5ba7a1d2/attachment.asc>

More information about the ffmpeg-devel mailing list