[FFmpeg-devel] [PATCH] avformat/avidec: ensure that palette does not contain the BottomUp info.

[Benoit Fouet]

Hi,

----- Mail original -----
> Hi,
> 
> ----- Mail original -----
> > On Tue, Sep 23, 2014 at 10:19:17AM +0200, Benoit Fouet wrote:
> 
> > > Here is a patch to illustrate this...
> > 
> > this looks better but:
> > 
> > 
> > [...]
> > > -                ff_put_bmp_header(pb, enc, ff_codec_bmp_tags, 0,
> > > 0);
> > > +                if (keep_height) {
> > > +                    enc->extradata_size -= 9;
> > > +                    if (!enc->extradata_size)
> > > +                        av_freep(&enc->extradata);
> > > +                }
> > 
> > what if extradata is stored in 2 files, the 2nd muxer would no
> > longer
> > see it
> > also the muxer shouldnt change the encoders/demuxer extradata
> > 
> > and cant all this logic be put in ff_put_bmp_header() ?
> > might even be simpler
> > 
> 
> Do you mean that ff_put_bmp_header() would check for the BottomUp
> presence and not negate height in this case, and also only write the
> palette in the stream?
> 

Patch attached, just in case this is what you meant...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avformat-riffenc-extend-ff_put_bmp_header-to-be-able.patch
Type: text/x-patch
Size: 1781 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140923/28f5905e/attachment.bin>