[FFmpeg-devel] [PATCH 1/2] Kill timed SRT

Nicolas George george at nsup.org
Mon Sep 29 17:42:09 CEST 2014

L'octidi 28 fructidor, an CCXXII, Clément Bœsch a écrit :
> ---
>  libavcodec/srtdec.c       | 33 +++----------------------------
>  libavcodec/srtenc.c       | 49 ++---------------------------------------------
>  libavformat/matroska.c    |  1 -
>  libavformat/matroskaenc.c | 45 +------------------------------------------
>  libavformat/srtenc.c      | 11 ++++-------
>  5 files changed, 10 insertions(+), 129 deletions(-)

I am in favour of doing this, and a quick glance at the code seems ok.

I have a small doubt about the handling of "move": it seems that with the
timed srt case, \move(x,y) is translated into "X: Y:" in the timestamp line
of the packet payload, while in the clean srt case it is dropped: should it
not be translated into side data? That is not something changed by the
patch, but the patch removes the "move" callback altogether, making the
issue less obvious, if there is one.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140929/3a206a67/attachment.asc>

More information about the ffmpeg-devel mailing list