[FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

[Michael Niedermayer]

On Tue, Sep 30, 2014 at 11:15:06AM +0200, Benoit Fouet wrote:
> Hi,
> 
> ----- Mail original -----
> > On Tue, Sep 30, 2014 at 09:45:47AM +0200, Benoit Fouet wrote:
> > > Hi,
> > > 
> > > ----- Mail original -----
> > > > On Mon, Sep 29, 2014 at 03:31:36PM +0200, Benoit Fouet wrote:
> > > >
> > > 
> > > [...]
> > > 
> > > > does this ensure that the sps is before the pps ?
> > > > if not that might be the reason for the warnings
> > > > 
> > > 
> > > It does not. I can update this so that when the pps is seen and not
> > > the sps, it prepends the sps to the pps.
> > 
> > please do, sps should be before the pps
> > 
> 
> Done, new patch attached.

probably ok, should i apply it ?


> Also, it would be cool if someone had a sample with only SPS in the stream, to check that the copy of PPS from AVCC works fine too.

yes, but i suspect this could be more rare

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140930/935d163c/attachment.asc>