[FFmpeg-devel] Ticket 4386 : crash create by previous patch

Michael Niedermayer michaelni at gmx.at
Wed Apr 1 20:22:44 CEST 2015


On Mon, Mar 30, 2015 at 11:11:53PM +0200, Martin Vignali wrote:
> Hello,
> 
> After some research, the crash when reading exr Piz file (ticket 4386),
> appear with this patch :
> https://github.com/FFmpeg/FFmpeg/commit/586ba24ff29468d2a4ee843a9650feea5b2be6f6
> 
> if, i use the previous line :
> memset(lut + k, 0, (USHORT_RANGE - k) * 2);
> 
> instead of the new one :
> memset(lut + k * 2, 0, (USHORT_RANGE - k) * 2);
> 
> crash disappear.
> 
> But i suppose, this previous patch have been made for a reason...

yes or it was a mistake mixing the sizeofs up
either way, its definitly wrong as it is now so reverted, i dont want
to leave such out of array access issues open ...

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150401/b5d13426/attachment.asc>


More information about the ffmpeg-devel mailing list