[FFmpeg-devel] Patch for High color and High bit-depth support

Debargha Mukherjee debargha at google.com
Thu Apr 2 21:19:50 CEST 2015


On Wed, Apr 1, 2015 at 3:11 PM, Debargha Mukherjee <debargha at google.com>
wrote:

> Updated patch.
>
> On Wed, Apr 1, 2015 at 3:10 PM, Debargha Mukherjee <debargha at google.com>
> wrote:
>
>>
>>
>> On Tue, Mar 31, 2015 at 4:16 PM, James Zern <jzern at google.com> wrote:
>>
>>> On Mon, Mar 30, 2015 at 10:26 AM, Debargha Mukherjee
>>> <debargha at google.com> wrote:
>>> > On Fri, Mar 27, 2015 at 8:07 PM, James Zern <jzern at google.com> wrote:
>>> >
>>> >> On Fri, Mar 27, 2015 at 6:58 PM, Debargha Mukherjee <
>>> debargha at google.com>
>>> >> wrote:
>>> >> > [...]
>>> >>
>>> >> > +#if CONFIG_LIBVPX_VP9_ENCODER && defined(VPX_IMG_FMT_HIGHBITDEPTH)
>>> >> > +static int set_pix_fmt(AVCodecContext *avctx, struct
>>> vpx_codec_enc_cfg
>>> >> *enccfg,
>>> >> > +                       vpx_codec_flags_t *flags, vpx_img_fmt_t
>>> >> *img_fmt) {
>>> >> > +    if (avctx->codec_id == AV_CODEC_ID_VP8 && avctx->pix_fmt !=
>>> >> AV_PIX_FMT_YUV420P) {
>>> >> >
>>> >>
>>> >> couldn't you just check a codec capability? what happens when vp9 is
>>> >> configured
>>> >> with high bitdepth encoding disabled?
>>> >>
>>> >
>>> > I wanted to insulate against compiling with an older version of libvpx
>>> that
>>> > did not have the highbitdepth flags defined. This is how we did the
>>> > libvpxdec.
>>> > I have added a codec caps check also to the code.
>>> >
>>>
>>> OK, but if you're checking for VPX_IMG_FMT_HIGHBITDEPTH then couldn't
>>> you just rely on the presence of the codec capability? If the mapping
>>> is for vp9 only then cap+vp9 check is all right, you can drop the vp8
>>> check as that code can't be reached (maybe add an av_assert).
>>>
>>
>> Removed the vp8 check.
>>
>
Updated patch to handle the checks better.


>
>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>
>>
>>
>> --
>> Debargha Mukherjee, Ph.D.
>> Staff Software Engineer,
>> Google, Inc.
>> Email: debargha at google.com
>> Phone: 408-234-5956 (cell)
>>
>
>
>
> --
> Debargha Mukherjee, Ph.D.
> Staff Software Engineer,
> Google, Inc.
> Email: debargha at google.com
> Phone: 408-234-5956 (cell)
>



-- 
Debargha Mukherjee, Ph.D.
Staff Software Engineer,
Google, Inc.
Email: debargha at google.com
Phone: 408-234-5956 (cell)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Support-for-VP9-high-color-high-bit-depth-encoding.patch
Type: text/x-patch
Size: 8156 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150402/db04d090/attachment.bin>


More information about the ffmpeg-devel mailing list