[FFmpeg-devel] [PATCH] matroskadec: export cover art correctly

[Michael Niedermayer]

On Fri, Apr 03, 2015 at 04:11:53PM +0200, wm4 wrote:
> Generally, libavformat exports cover art pictures as video streams with
> 1 packet and AV_DISPOSITION_ATTACHED_PIC set. Only matroskadec exported
> it as attachment with codec_id set to AV_CODEC_ID_MJPEG.
> 
> Obviously, this should be consistent, so change the Matroska demuxer to
> export a AV_DISPOSITION_ATTACHED_PIC pseudo video stream.
> 
> Matroska muxing is probably incorrect too. I know that it can create
> broken files with an audio track and just 1 video frame when e.g.
> remuxing mp3 with APIC to mkv. But for now this commit does not change
> anything about muxing, and also continues to write attachments with
> AV_CODEC_ID_MJPEG should the muxer application have special knowledge
> that the Matroska is broken in this way.
> 
> Fixes trac #4423.
> ---
>  libavformat/matroska.c    |  9 +++++++--
>  libavformat/matroska.h    |  1 +
>  libavformat/matroskadec.c | 41 +++++++++++++++++++++++++++++++----------
>  libavformat/matroskaenc.c |  5 +++++
>  4 files changed, 44 insertions(+), 12 deletions(-)

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150404/bd6063d0/attachment.asc>