[FFmpeg-devel] [PATCH] avfilter: handle error in query_formats() in bunch of filters

[Michael Niedermayer]

On Sat, Apr 04, 2015 at 10:33:44AM +0000, Paul B Mahol wrote:
[...]
> diff --git a/libavfilter/vf_cropdetect.c b/libavfilter/vf_cropdetect.c
> index e8492cd..485ae69 100644
> --- a/libavfilter/vf_cropdetect.c
> +++ b/libavfilter/vf_cropdetect.c
> @@ -62,8 +62,10 @@ static int query_formats(AVFilterContext *ctx)
>          AV_PIX_FMT_NONE
>      };
>  
> -    ff_set_common_formats(ctx, ff_make_format_list(pix_fmts));
> -    return 0;
> +    AVFilterFormats *fmts_list = ff_make_format_list(pix_fmts);

mixed declarations and code


[...]
> diff --git a/libavfilter/vf_histogram.c b/libavfilter/vf_histogram.c
> index 40ec400..a4a7f8c 100644
> --- a/libavfilter/vf_histogram.c
> +++ b/libavfilter/vf_histogram.c
> @@ -121,9 +121,10 @@ static int query_formats(AVFilterContext *ctx)
>          av_assert0(0);
>      }
>  
> -    ff_set_common_formats(ctx, ff_make_format_list(pix_fmts));
> -
> -    return 0;
> +    AVFilterFormats *fmts_list = ff_make_format_list(pix_fmts);

mixed declarations and code

rest probably ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150405/e0a0f157/attachment.asc>