[FFmpeg-devel] [PATCH 3/3] avformat: add youtube-dl based demuxer

Gilles Chanteperdrix gilles.chanteperdrix at xenomai.org
Wed Apr 8 22:20:59 CEST 2015


On Wed, Apr 08, 2015 at 08:52:12PM +0100, Derek Buitenhuis wrote:
> On 4/8/2015 6:16 PM, Gilles Chanteperdrix wrote:
> > Signed-off-by: Gilles Chanteperdrix <gilles.chanteperdrix at xenomai.org>
> > ---
> >  libavformat/Makefile     |   1 +
> >  libavformat/allformats.c |   1 +
> >  libavformat/youtubedl.c  | 221 +++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 223 insertions(+)
> >  create mode 100644 libavformat/youtubedl.c
> 
> I must say this is incredibly dumb and has no place at all in libav*format*. This
> should be done in the layer above whatever avformat (and not even to mention the
> hilarity of running a cli script from a library).
> 
> I am registering my dissent here, in writing, so I can point to it in the future
> when asked (and I always get asked).
> 
> NOTE: I am sure people will respond and explain how avformat is totally the right
> place, just like it was the right place for a dir listing api, and an http server,
> and probably soon systemd. I am not going to respond, or otherwise engage in
> mailing list flamewars. This mail is read-only.

For my defense: I asked if it would not be to ugly before starting
and (mis)writing it.

-- 
					    Gilles.


More information about the ffmpeg-devel mailing list