[FFmpeg-devel] [PATCH] libavformat/http.c: Make http-listen work as an input stream.

Nicolas George george at nsup.org
Sat Apr 11 20:10:16 CEST 2015


Le septidi 17 germinal, an CCXXIII, Stephan Holljes a écrit :
> From bbd8fc4e700968a977b30850b7be3ec39bad3531 Mon Sep 17 00:00:00 2001
> From: Stephan Holljes <klaxa1337 at googlemail.com>
> Date: Mon, 6 Apr 2015 20:23:01 +0200
> Subject: [PATCH 2/2] libavformat/http.c: Make http-listen work as an input
>  stream.
> 
> With this patch http can be used to listen for POST data to be used as an input stream.
> 
> Signed-off-by: Stephan Holljes <klaxa1337 at googlemail.com>
> ---
>  doc/protocols.texi | 4 +++-
>  libavformat/http.c | 7 +++++--
>  2 files changed, 8 insertions(+), 3 deletions(-)

You make it seem too easy. I see nothing wrong with the patch.

But Lukasz had a remark, you are expected to acknowledge it before things
can move on. Not necessarily obey it, mind, you can also explain that you
disagree ("this feature is too green and unstable, adding an example that
early would encourage people to use it before it is really ready"), but you
have to give the direction.

Since this comes in GSoC for a mentored project, you will get more guidance
than a random dude proposing a similar patch on their own, but basically
this is still considered your patch.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150411/131c09dd/attachment.asc>


More information about the ffmpeg-devel mailing list