[FFmpeg-devel] [PATCH v2] examples: add flac_test

wm4 nfxjfg at googlemail.com
Wed Apr 15 12:37:29 CEST 2015


On Wed, 15 Apr 2015 12:21:01 +0200
Nicolas George <george at nsup.org> wrote:

> Le sextidi 26 germinal, an CCXXIII, wm4 a écrit :
> > Both ffmpeg.c and the API are very complex, so it's obvious that
> > ffmpeg.c can't possibly be using all possible ways the API can be used.
> 
> FUD again.
> 
> > If you really want a concrete example: av_seek_frame() is not used in
> > any of the command line tools.
> 
> At last, ONE specific example.
> 
> Now, the corresponding question: where is your patch to make ffmpeg.c use
> av_seek_frame()?

What if I want to call av_seek_frame() in pseudo-random intervals with
different flags each? How do I make it to pass a specific stream
argument? There are a number of other public API functions that are not
used in any of the tools, probably because they don't need it. How
would you test these?

Would you really litter ffmpeg.c with extra code just for testing, all
with the argument that it should be part of ffmpeg.c instead of
separate tests?

Here's another example that I actually hit: what if you set a
channel layout on a SwrContext, open it, close it, set another channel
layout, and open it again? (This used to crash, it actually happened to
me in my code.) How would you mess this into ffmpeg.c?

What the hell are you even thinking?


More information about the ffmpeg-devel mailing list