[FFmpeg-devel] [PATCH 2/2] fate: gapless: fix mp3 tests

Michael Niedermayer michaelni at gmx.at
Mon Apr 20 21:45:08 CEST 2015


On Mon, Apr 20, 2015 at 07:36:52PM +0200, wm4 wrote:
> Seeking to a negative time did not have the desired effect of seeking to
> the next valid position (the file start). On the other hand, just
> "-ss 0" will normally seek to a position higher than 0, because it adds
> the start time of the file. (The start time is not 0 because the gapless
> code skips a few samples from the start.)
> 
> Fix this by using the "-seek_timestamp 1" option, which makes "-ss 0" do
> what you'd expect it would do.
> 
> Also put the -ss option at the right place, before -i. This actually
> makes it seek, instead of something completely else. The ".out-3" test
> is no different in the -usetoc 0/1 cases, because the seeking is
> inaccurate (in both cases).
> ---
> In other news, gapless still breaks with seeking, and the last part of
> the tests (...out-3 lines) test something broken. I conclude it can't
> be made work without some form of full indexing.
> ---
>  tests/fate-run.sh                | 13 +++++--------
>  tests/ref/fate/gapless-mp3       |  4 ++--
>  tests/ref/fate/gapless-mp3-notoc |  4 ++--
>  3 files changed, 9 insertions(+), 12 deletions(-)

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150420/18728a6a/attachment.asc>


More information about the ffmpeg-devel mailing list