[FFmpeg-devel] [FFmpeg-cvslog] libavcodec: Add FLAC API test

Clément Bœsch u at pkh.me
Tue Apr 21 05:19:24 CEST 2015


On Mon, Apr 20, 2015 at 02:37:27PM +0200, Ludmila Glinskih wrote:
> ffmpeg | branch: master | Ludmila Glinskih <lglinskih at gmail.com> | Mon Apr 20 03:03:08 2015 +0300| [be70c79af2bbbf8818707075ebc376d0be137582] | committer: Michael Niedermayer
> 
> libavcodec: Add FLAC API test
> 
> Signed-off-by: Ludmila Glinskih <lglinskih at gmail.com>
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=be70c79af2bbbf8818707075ebc376d0be137582
> ---
> 
>  libavcodec/Makefile        |    1 +
>  libavcodec/api-flac-test.c |  290 ++++++++++++++++++++++++++++++++++++++++++++
>  tests/fate/libavcodec.mak  |    6 +
>  3 files changed, 297 insertions(+)
> 
[...]

> +TESTPROGS += api-flac

Mmh... no TESTPROGRES-$(CONFIG_FLAC_DECODER) or similar?

[...]
> +    if (!ctx)
> +    {

Sorry to comment on such superficial issue, but this style (repeated all
over the file) is an obvious violation of the coding style of the project.
If the author or the person pushing the patch could fix this, that would
be appreciated.

Thanks

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150421/bc1b906c/attachment.asc>


More information about the ffmpeg-devel mailing list