[FFmpeg-devel] [PATCH v4] libavcodec: Add FLAC API test

[Kieran Kunhya]

On 21 April 2015 at 21:52, Ludmila Glinskih <lglinskih at gmail.com> wrote:
> Sorry for the delay, thanks for comments!
>
> вт, 21 апр. 2015 г. в 1:40, Kieran Kunhya <kierank at obe.tv>:
>
>> On 20 April 2015 at 01:03, Ludmila Glinskih <lglinskih at gmail.com> wrote:
>> > Signed-off-by: Ludmila Glinskih <lglinskih at gmail.com>
>> > ---
>> >  libavcodec/Makefile        |   1 +
>> >  libavcodec/api-flac-test.c | 290
>> +++++++++++++++++++++++++++++++++++++++++++++
>>
>> I would put this in its own directory.
>>
> Do you mean libavcodec/api directory? I think the best is to put it in the
> tests/api directory, but don't know how to make it (now).
>
>
>> I think the next thing you should work on is a simple, shared version
>> of framecrc so these tests can be integrated into FATE.
>> Or you can use the framecrc in libavformat - I have no preference.
>>
> Now my test is running with all FATE tests, doesn't this mean, that it is
> integrated?
> Can you please explain to me, why framecrc is so important?

It should be possible for your tests to use the same input test clips
and produce the same output data which are tested using stored
framecrcs in FATE currently. It's easy when you are encoding FLAC and
then decoding it but for example there are official h264 samples which
need to be decoded and checked for accuracy.

Please let me know if this doesn't make sense.

Kieran