[FFmpeg-devel] [PATCH] Using size_t* instead of int** for dynarrays and add support for large boxes

Niklesh Lalwani lalwani1994 at gmail.com
Mon Apr 27 13:48:31 CEST 2015


>
> On Mon, Apr 27, 2015 at 2:25 PM, wm4 <nfxjfg at googlemail.com> wrote:
>
> This looks hacky. av_dynarray_add() is supposed to many an array of
> pointers, and here you twist it enough to reinterpret-cast an int to a
> pointer.
>
> Yes, this looks hacky. Earlier I was using int **number, passing address
of element to add, and then using *number[i] to get the value of the
element as you can see in the patch.

> I think av_dynarray2_add() might be the correct function to
> use here. Then your array can actually be an array of ints.
> (These dynarray functions are really a mess...)
> _______________________________________________
>
> I can try av_dynarray2_add(). Which one of these three do you think will
be a better choice?

-- 
Niklesh Lalwani
Third Year Undergraduate
Electrical Engineering
IIT Bombay


More information about the ffmpeg-devel mailing list