[FFmpeg-devel] [PATCH] libavutil: Make changes in softfloat needed for fixed point aac decoder.

Michael Niedermayer michaelni at gmx.at
Wed Apr 29 17:22:04 CEST 2015


On Wed, Apr 29, 2015 at 12:13:53PM +0000, Nedeljko Babic wrote:
> Ok, I'll split this patch some more and since this takes already too long I
> will eliminate any change that is not absolutely necessary for implementation
> of fixed point aac decoder (I am thinking here on new recip and div functions).
> 
> Since there will be two or three new patches from this patch I'll resubmit them
> as a new patch set (as oppose resending them as replay to this thread).
> 
> Regarding comments about changes to exponent, it is change that is needed for
> this soft float to be usable in implementation of fixed point aac decoder with
> the new functions that we are adding.
> 
> I could also change the value of ONE_BITS and adjust the code accordingly, but
> this comes down to the same.
> 
> The alternative would be to change the code that is already written (and
> probably to recalculate some of the tables) but that is much more work than just
> changing exponent here.
> Since softfloat is not used anywhere currently, I don't see how this can be
> justified.
> 

> Maybe the comment in commit message should specify that exponent is changed for
> softfloat to be usable in fixed aac decoder, or something similar?

yes and that patch should preferably change nothing else than the
exponent

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150429/a3003abc/attachment.asc>


More information about the ffmpeg-devel mailing list