[FFmpeg-devel] [PATCH]lavc/dvbsub: Do not fail on clut depth 0

[wm4]

On Tue, 4 Aug 2015 13:18:54 +0000 (UTC)
Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:

> wm4 <nfxjfg <at> googlemail.com> writes:
> 
> > Seems like a case for AV_EF_EXPLODE.
> 
> I wonder if this isn't a bug in our decoder given 
> that the output looks very ugly and not an issue 
> with the given stream but somebody will have to 
> check.
> I opened ticket #4754 for the visual issue.
> 
> > Also, why can't you send proper git patches?
> 
> I find it very uncomfortable and since you don't 
> have to commit them, I hope it does not bother 
> you too much.

They lack the commit message, so this bothers me very much. It's
important to ensure that commit messages provide enough information, so
they are definitely part of a patch review. Plus not sending complete
patches sets a bad example.

Setting up git-send-email is not that hard, and it will be much more
comfortable than creating a diff, opening your mail client, attaching
the patch, and somehow imperfectly replicating the commit message in
your email.