[FFmpeg-devel] [libav-devel] [PATCH 1/6] avutil: remove deprecation of qscale_{table, type}, qstride

[Clément Bœsch]

On Sat, Aug 08, 2015 at 02:49:38PM +0200, wm4 wrote:
> On Sat, 8 Aug 2015 14:31:21 +0200
> Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> 
> > On Sat, Aug 8, 2015 at 1:36 PM, Andreas Cadhalpun
> > <andreas.cadhalpun at googlemail.com> wrote:
> > > They are used by the not deprecated av_frame_{g,s}et_qp_table.
> > >
> > > Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> > > ---
> > >  libavutil/frame.h | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/libavutil/frame.h b/libavutil/frame.h
> > > index 196b578..c4e333c 100644
> > > --- a/libavutil/frame.h
> > > +++ b/libavutil/frame.h
> > > @@ -285,21 +285,19 @@ typedef struct AVFrame {
> > >  #if FF_API_AVFRAME_LAVC
> > >      attribute_deprecated
> > >      int reference;
> > > -
> > > +#endif
> 
> Stray change.
> 
> > >      /**
> > >       * QP table
> > >       */
> > > -    attribute_deprecated
> > >      int8_t *qscale_table;
> > >      /**
> > >       * QP store stride
> > >       */
> > > -    attribute_deprecated
> > >      int qstride;
> > >
> > > -    attribute_deprecated
> > >      int qscale_type;
> > >
> > > +#if FF_API_AVFRAME_LAVC
> > >      /**
> > >       * mbskip_table[mb]>=1 if MB didn't change
> > >       * stride= mb_width = (width+15)>>4
> > 
> > 
> > Didn't this stuff move into sidedata
> 
> In FFmpeg. It's completely gone in Libav. (FFmpeg "needs" it for their
> relatively useless postproc filters.)
> 

Side note: users can need them as well. I personally use this for a
different purpose that post processing; since it can for example give
insight on the relevance of certain areas of the video, it is useful for
various "free" (understand fast / real time) analysis of a stream.

BTW, I have a local WIP to display them in codecview filter (as with what
you can get with -debug vis_qp which I'll try to get done soonish.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150808/2e6b1643/attachment.sig>