[FFmpeg-devel] [PATCH 10/13] ffmpeg: replace deprecated av_log_ask_for_sample with av_log

Michael Niedermayer michael at niedermayer.cc
Sun Aug 9 01:19:17 CEST 2015


On Sat, Aug 08, 2015 at 09:55:03PM +0200, Andreas Cadhalpun wrote:
> On 08.08.2015 18:01, Hendrik Leppkes wrote:
> > On Sat, Aug 8, 2015 at 5:55 PM, Michael Niedermayer
> > <michael at niedermayer.cc> wrote:
> >> On Sat, Aug 08, 2015 at 01:32:56PM +0200, Andreas Cadhalpun wrote:
> >> iam not objecting to the change but
> >> wouldnt it make sense for ffmpeg/ffplay/ffserver and other tools
> >> to be able to ask for a sample ?
> >>
> >> also we are searching for a sample that has rotation angles which are
> >> not i*90deg. Our code does potentially not handle these optimally but
> >> I dont know maybe we do handle it fine, i would need a real world
> >> sample to see what such angle is used for / when it is used to know
> >> what is the best thing to do in such case ..
> >>
> > 
> > As this is only two small cases, maybe should just put the request
> > text in these av_logs instead.
> 
> Patch doing that attached.

LGTM

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150809/eac0e913/attachment.sig>


More information about the ffmpeg-devel mailing list