[FFmpeg-devel] [libav-devel] [PATCH 2/6] avutil: remove av_reverse deprecation

[Michael Niedermayer]

On Sat, Aug 08, 2015 at 09:38:39PM +0200, Andreas Cadhalpun wrote:
> On 08.08.2015 18:40, Martin Storsjö wrote:
> > As Hendrik said, public data symbols are problematic from a portability point of view
> > (they behave differently than public functions in DLLs and require jumping through
> > extra hoops, which we've chosen not to jump through - the MSVC portability is quite
> > tricky enough as it is without bothering with this aspect).
> 
> Thanks for the explanation. (It would have been good to mention this in APIchanges
> and/or the commit message adding FF_API_AV_REVERSE.)
> 
> > The correct solution is to drop this and do the same thing as for e.g. log2_tab.o,
> > which is duplicated in all libs that use it (for this table, it'd be libavcodec and
> > libavutil only).
> 
> Attached patch does that.
> 
> Best regards,
> Andreas
> 
> 

>  libavcodec/Makefile     |    2 +-
>  libavcodec/mathops.h    |    1 -
>  libavcodec/mathtables.c |   19 -------------------
>  libavcodec/reverse.c    |    1 +
>  libavutil/Makefile      |    1 +
>  libavutil/eval.c        |    3 ++-
>  libavutil/internal.h    |    2 ++
>  libavutil/reverse.c     |   40 ++++++++++++++++++++++++++++++++++++++++
>  8 files changed, 47 insertions(+), 22 deletions(-)
> 486ad31990d3654c44828b6754917990e5e59a81  0002-avutil-add-ff_reverse-as-av_reverse-replacement.patch
> From 3bfd1259e37f63442e025ba3ab7d49b79681e8fb Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Sat, 8 Aug 2015 10:41:34 +0200
> Subject: [PATCH 2/6] avutil: add ff_reverse as av_reverse replacement
> 
> The table is used in libavutil/eval.c.
> 
> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>

LGTM

thx

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150809/3158fa29/attachment.sig>