[FFmpeg-devel] [PATCHv2] avcodec/g729: add g729_parser

[Michael Niedermayer]

On Tue, Aug 11, 2015 at 07:28:52PM -0400, Ganesh Ajjanagadde wrote:
> On Tue, Aug 11, 2015 at 7:00 PM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > On Tue, Aug 11, 2015 at 06:08:54PM -0400, Ganesh Ajjanagadde wrote:
> >> On Tue, Aug 11, 2015 at 5:16 PM, Michael Niedermayer
> >> <michael at niedermayer.cc> wrote:
> >> > On Tue, Aug 11, 2015 at 01:04:09PM -0400, Ganesh Ajjanagadde wrote:
> >> >> Add trivial g729 parser; fixes Ticket4753
> >> >>
> >> >> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> >> >> ---
> >> >>  libavcodec/Makefile      |  1 +
> >> >>  libavcodec/allcodecs.c   |  1 +
> >> >>  libavcodec/g729.h        |  4 +++
> >> >>  libavcodec/g729_parser.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++++
> >> >>  4 files changed, 95 insertions(+)
> >> >>  create mode 100644 libavcodec/g729_parser.c
> >> >
> >> > applied
> >> >
> >> > thanks
> >>
> >> Noticed your commit after this (899202) to replace codec_id check with assert.
> >> I essentially copied the parser from libavcodec/gsm_parser.c,
> >> so you might want to change that file in similar fashion as well.
> >
> > yes, thanks
> 
> Perhaps useful to you (may have some false positives), but
> avctx->codec_id check is done in:
> mpegaudio_parser.c, rv34_parser.c, vp3_parser.c, aac_ac3_parser.c,
> mpegvideo_parser.c

these all support multiple codec_ids, so the checks in them should
be fine

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150812/45109e0e/attachment.sig>