[FFmpeg-devel] [PATCH] doc/developer: Suggest everyone to help with patch reviews

Michael Niedermayer michael at niedermayer.cc
Thu Aug 13 23:28:51 CEST 2015


On Thu, Aug 13, 2015 at 01:29:46PM -0400, Ganesh Ajjanagadde wrote:
> On Thu, Aug 13, 2015 at 1:21 PM, compn <tempn at mi.rr.com> wrote:
> > On Thu, 13 Aug 2015 16:08:12 +0000
> > Timothy Gu <timothygu99 at gmail.com> wrote:
> >
> >> On Thu, Aug 13, 2015 at 8:38 AM Michael Niedermayer <michaelni at gmx.at>
> >> wrote:
> >>
> >> > From: Michael Niedermayer <michael at niedermayer.cc>
> >> >
> >> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >> > ---
> >> >  doc/developer.texi |    4 ++++
> >> >  1 file changed, 4 insertions(+)
> >> >
> >> > diff --git a/doc/developer.texi b/doc/developer.texi
> >> > index 7e9f0b2..db7fcb7 100644
> >> > --- a/doc/developer.texi
> >> > +++ b/doc/developer.texi
> >> > @@ -637,6 +637,10 @@ not related to the comments received during
> >> > review. Such patches will
> >> >  be rejected. Instead, submit significant changes or new features as
> >> >  separate patches.
> >> >
> >> > +Everyone is welcome to review patches. Also if you are waiting for
> >> > your patch
> >> >
> >>
> >>
> >> > +to be reveiwed, please consider to help review other patches,
> >> > thats a great way
> >> >
> >>
> >> reviewed
> >> consider helping
> >> that is
> >>
> >>
> >> > +to get everyones, and thus also your patch reveiwed quicker.
> >> >
> >>
> >> This sounds awkward. How about just:
> >>
> >> to get everyone's patches reviewed sooner.

all fixed


> >>
> >
> > good idea michael.
> >
> > tims' changes also LGTM
> 
> LGTM

applied

thanks everyone for the reviews!

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150813/242fab24/attachment.sig>


More information about the ffmpeg-devel mailing list