[FFmpeg-devel] [PATCH] aacdec_template: remove obsolete warning suppression

[Michael Niedermayer]

On Thu, Aug 13, 2015 at 08:57:12PM -0400, Ganesh Ajjanagadde wrote:
> On Thu, Jul 30, 2015 at 4:06 PM, Ganesh Ajjanagadde
> <gajjanagadde at gmail.com> wrote:
> > Signed-off-by: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
> > ---
> >  libavcodec/aacdec_template.c | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> > diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c
> > index 2f270bc..d7849da 100644
> > --- a/libavcodec/aacdec_template.c
> > +++ b/libavcodec/aacdec_template.c
> > @@ -1907,11 +1907,6 @@ static int decode_ics(AACContext *ac, SingleChannelElement *sce,
> >                   ac->oc[1].m4ac.object_type == AOT_ER_AAC_LD ||
> >                   ac->oc[1].m4ac.object_type == AOT_ER_AAC_ELD;
> >
> > -    /* This assignment is to silence a GCC warning about the variable being used
> > -     * uninitialized when in fact it always is.
> > -     */
> > -    pulse.num_pulse = 0;
> > -
> >      global_gain = get_bits(gb, 8);
> >
> >      if (!common_window && !scale_flag) {
> > --
> > 2.5.0
> >
> 
> I guess I should have clarified the intent of this patch:
> This particular code only existed (as shown in the comment) to work
> around a compiler bug regarding diagnostics.
> Said compiler bug does not affect GCC of any recent vintage (I run the
> latest 5.2, but tested 4.8.1),

many people and also developers still use older compilers
false positive warnings distract from real issues

do you know in which version of gcc this was fixed?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150814/5b401ff5/attachment.sig>