[FFmpeg-devel] [PATCH] avfilter/sine: support expression in the number of output samples

[Nicolas George]

L'octidi 28 thermidor, an CCXXIII, Clement Boesch a écrit :
> ---
> Seems a bit tricky to do it in asetnsamples so... Might be relevant to do the
> same in aevalsrc as well.

How does it affect speed? One of the two purposes of sine is to be fast (the
other is to be bit-exact), and I am a bit afraid that the expression
evaluation is slow, even for constants.

Apart from that, no objection and LGTM, but I am not familiar enough with
the expr API to spot subtle mistakes.

And at some point it will be necessary to factor all this mess of
expressions.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150815/e3af07bf/attachment.sig>