[FFmpeg-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Sun Aug 16 19:33:58 CEST 2015


On 16.08.2015 05:36, Michael Niedermayer wrote:
> On Sun, Aug 16, 2015 at 05:27:12AM +0200, Michael Niedermayer wrote:
>> On Sat, Aug 08, 2015 at 01:37:16PM +0200, Andreas Cadhalpun wrote:
>>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> [...]
>>
>>>  #ifndef FF_API_NOCONST_GET_NAME
>>> -#define FF_API_NOCONST_GET_NAME             (LIBAVFILTER_VERSION_MAJOR < 6)
>>> +#define FF_API_NOCONST_GET_NAME             (LIBAVFILTER_VERSION_MAJOR < 7)
>>>  #endif
>>
>> why ?

That's because Vittorio suggested it in his similar patch on libav-devel.
I agree that postponing this is not really necessary.

> rest of the patch LGTM

Taking a closer look, there are also lots of other APIs that could be
removed with this bump, because they are only rarely used:
FF_API_MISSING_SAMPLE
FF_API_OPT_TYPE_METADATA
FF_API_DLOG
FF_API_VOXWARE
FF_API_AC_VLC
FF_API_OLD_MSMPEG4
FF_ASPECT_EXTENDED
FF_API_ARCH_ALPHA
FF_API_NEG_LINESIZES
FF_API_ARCH_SH4
FF_API_ARCH_SPARC
FF_API_IDCT_XVIDMMX
FF_API_AVFILTER_OPEN
FF_API_AVFILTER_INIT_FILTER
FF_API_NOCONST_GET_NAME
FF_API_LAVF_FRAC

Removing some or all of these would make much more sense than removing the
widely used FF_API_PIX_FMT and FF_API_AVFRAME_LAVC.

So I'm not going to apply this patch for the moment.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list