[FFmpeg-devel] [PATCH]Postpone vdpau removal

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Wed Aug 19 20:52:25 CEST 2015


On 19.08.2015 01:08, Philip Langdale wrote:
> On 2015-08-18 15:59, Andreas Cadhalpun wrote:
>> On 18.08.2015 23:15, Philip Langdale wrote:
>>> Do we have any known applications that still use the old API.
>>> Even mplayer, of all things, uses the new API.
>>
>> I'm not exactly sure what you meant here, but FF_API_VDPAU
>> is mainly about the (AV_)PIX_FMT_VDPAU_* pixel formats, which
>> mplayer is still using, e.g. [1].
> 
> mplayer contains code that handles these formats, but by using the new
> API, it will never actually see content on those formats. This is now
> dead code in mplayer.

But that code still gets compiled, so when I try building mplayer
with a FFmpeg version without FF_API_CAP_VDPAU I get the following error:
libvo/vo_vdpau.c:177:34: error: array type has incomplete element type
 static struct vdpau_render_state          surface_render[MAX_VIDEO_SURFACES];
                                  ^

Do you mean that this code can just be removed?

Best regards,
Andreas


More information about the ffmpeg-devel mailing list